Usagov 2132 hide contact info by page #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gion and block positions
…nt Administrator role
…called by twig file. Forbidden pages added to mobile
…origin' into USAGOV-2132-hide-contact-info-by-page
akf
reviewed
Feb 1, 2025
There was a problem hiding this comment.
I took a look at this and unfortunately the blocks are broken for me. I now remember running into this before -- the blocks you exported as config are somewhat present, but are "broken."
I can get to the edit pages for them by clicking "configure" next to the message "This block is broken or missing" when viewing a node. So I can find my way to, for example, http://localhost/admin/structure/block/manage/usagov_topnavphone and I can see the Visibility configuration, but the Block description says "Broken/Missing."
The new blocks do not appear at /admin/content/block
Is this what you meant by "Content may be required for this to work." ?
…origin' into USAGOV-2132-hide-contact-info-by-page
…ture sync module, top phone nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2132
Description
Goal of this task is to hide call center info on certain pages.
Call center info can appear in the header, footer, and mobile menu.
Created new regions for this task
For this to work, config, code and content have to be in sync. To achieve this, I added a new module "Structure Sync". It allows for devs to export blocks, menus, and taxonomy content as config. Blocks are currently the only ones in use.
Type of Changes
Testing Instructions
You must run bin/composer install to gain access to the structure sync module.
Then, go to http://localhost/admin/structure/structure-sync/blocks.
Next, click on the Import custom blocks (safely) button
Contact info should not be visible the following pages:
New blocks can found under content blocks
Position of new block can be found at Block Layout
Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Testand add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.